Re: [PATCH] rbd: set discard alignment to zero

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks for the feedback, Ilya.

On Wed, 1 Nov 2017 18:14:04 +0100, Ilya Dryomov wrote:

> Yeah, discard_alignment == discard_granularity seems bogus.  The name
> is misleading too, but that probably comes from SBC, which talks about
> OPTIMAL UNMAP GRANULARITY and UNMAP GRANULARITY ALIGNMENT.
> 
> 0 is the default -- let's just drop discard_alignment assignment?

Works for me, if you'd prefer. I'll send through a v2 with this.

> Also, you quoted <disk>/<partition>/discard_alignment description, but
> this is about <disk>/discard_alignment.  This had me confused for
> a moment.

Oops, my bad. Will use the <disk> only description in the next round.

Cheers, David
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux