I'd love to find that we could avoid this... regards, Matt On Thu, Oct 12, 2017 at 12:27 AM, kefu chai <tchaikov@xxxxxxxxx> wrote: > hi all, > > > rocksdb's cmake script is using features[0] introduced by cmake > 2.8.12[1]. as install()[2] on 2.8.11 does not support "INCLUDES" > argument. hence, the build on el 7.{0,1,2} is broken now. but > http://docs.ceph.com/docs/master/start/os-recommendations/#luminous-12-2-z > claims that we support centos7.. > > the reason why we are not trouble now is that we are not > building/testing build on them now. > > so the question is, shall we support build on centos 7.{0,1,2} on > which cmake 2.8.11? if the answer is yes, we need to maintain the > patched rocksdb submodule in our fork. > > -- > [0] https://github.com/facebook/rocksdb/pull/2998 > [1] https://cmake.org/cmake/help/v2.8.12/cmake.html#command:install > [2] https://cmake.org/cmake/help/v2.8.11/cmake.html#command:install > > -- > Regards > Kefu Chai > -- > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Matt Benjamin Red Hat, Inc. 315 West Huron Street, Suite 140A Ann Arbor, Michigan 48103 http://www.redhat.com/en/technologies/storage tel. 734-821-5101 fax. 734-769-8938 cel. 734-216-5309 -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html