On Thu, Sep 7, 2017 at 4:53 PM, Joao Eduardo Luis <joao@xxxxxxx> wrote: > On 09/07/2017 05:00 AM, kefu chai wrote: >> >> hey Joao, >> >> while reviewing https://github.com/ceph/ceph/pull/17269, i found that >> there is no consumers of the payload of MPing replies. but apparently, >> we stuff it with the health status on purpose. do you happen to >> remember why we are doing so? if the feature/functionality depending >> on it is deprecated or removed or not implemented, probably we can >> just drop the logic to stuff the payload of MPing? > > > The only consumer, to date, and possibly ever until we (maybe) piggy-back on > it for heartbeats, is the ceph tool. > > We do consume that reply when we run `ceph ping mon.foo`. The interface is > through RadosClient, all the way up to the Objecter, and eventually up the > chain to the ceph tool. ahh, right! i missed MonClientPinger when grep'ing MPing in the source tree. thank you, Joao! -- Regards Kefu Chai -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
