When implemented it was generally though to be OK by reviewers, including yourself. https://github.com/ceph/ceph/pull/14821 Can I asked what changed to make it an issue now? Has there been some recent change in compilers on FreeBSD to make this an issue? It's a valid use of RAII in my humble opinion although it *appears* to be an unused variable. Odd this warning is not present on Linux and I wonder whether sanity prevailed in that regard? On Fri, Jul 21, 2017 at 7:04 AM, Willem Jan Withagen <wjw@xxxxxxxxxxx> wrote: > Op 20-7-2017 om 22:06 schreef Willem Jan Withagen: >> >> >> >> Op 20-7-2017 om 21:20 schreef Patrick Donnelly: >>> >>> On Thu, Jul 20, 2017 at 7:02 AM, Willem Jan Withagen <wjw@xxxxxxxxxxx> >>> wrote: >>>> >>>> Hi, >>>> >>>> I'm running in too many: >>>> /home/jenkins/workspace/ceph-master/src/test/bufferlist.cc:490:11: >>>> warning: unused variable 'unset_dumpable' [-Wunused-variable] >>>> PrCtl unset_dumpable; >>>> ^ >>>> >>>> for it to be by accident?? >>>> But why is this variable created in about a dozen functions? >>> >>> AFAICT, the intent by Brad in aef2a7b6ac5d0dafdac16d0d4cef42056c07b5a6 >>> is to prevent core dumps during the lifetime of certain objects. The >>> object is actually used indirectly via syscalls in its >>> constructo/destructor. >>> >>> Is there a nice way of silencing this warning for this code? >> >> I suspected as much as that. >> >> Likely there is a pragma that can be wrapped around the declaration. >> And then stick it in a macro, but I'm not sure that pragma will survice a >> macro. > > > Pragmas could work, but sticking them in a macro for both GCC and Clang is a > real mess. > Doing a (void) trick seems a lot easier. > > https://github.com/ceph/ceph/pull/16462 > > --WjW -- Cheers, Brad -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
