On 2-6-2017 16:36, Alfredo Deza wrote: > On Fri, Jun 2, 2017 at 6:42 AM, Willem Jan Withagen <wjw@xxxxxxxxxxx> wrote: >> Hi, >> >> During run-tox tests, ceph-disk complains that it is missing prettytable. >> It is however installed on my system, and I can load it. So that part >> works. But one way or another it is not loaded into the tox environment. >> >> How or what are all other dependancies loaded? >> Is there a config file where I need to add that this test needs prettytable? > > I am not sure what tox file you are running, but tox will create a > virtual environment where it installs dependencies > for the project you are testing. These dependencies should be defined > by the project, the tox file, or by configuring tox to > use dependencies installed system-wide. > > For example, in ceph-installer, we tell tox to install a dependency > that is only needed for tests like this: > > https://github.com/ceph/ceph-installer/blob/master/tox.ini#L5-L6 > > I think that prettytable is a Python dependency so you can go ahead > and add it there and it should work. > > This also sounds like a bug :) tox.ini contains: [testenv] setenv = VIRTUAL_ENV={envdir} CEPH_DISK={envbindir}/coverage run --append --source=ceph_disk -- {envbindir}/ceph-disk usedevelop = true deps = {env:NO_INDEX:} --use-wheel --find-links=file://{toxinidir}/wheelhouse -r{toxinidir}/requirements.txt -r{toxinidir}/test-requirements.txt ../ceph-detect-init So I added it to requirements.txt, and ran make tests. After that every thing is A-oke. Thanx, --WjW -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
