On Fri, May 5, 2017 at 3:11 PM, Willem Jan Withagen <wjw@xxxxxxxxxxx> wrote: > On 05-05-17 08:57, kefu chai wrote: >> On Fri, May 5, 2017 at 3:51 AM, Willem Jan Withagen <wjw@xxxxxxxxxxx> wrote: >>> >>> http://cephdev.digiware.nl:8180/jenkins/job/ceph-master/634/console >>> >>> Cmake fails on babletrace. >>> Uptill now babeltrace was optional, but if it is not really 100% >>> required I'll look into it in 2 weeks after my vacation. >>> Otherwise it would be nice if it was made optional again. >> >> Willem, we fixed some FindXXX.cmake scripts in >> https://github.com/ceph/ceph/pull/14951, that's why babel failed to be >> found in your environment, and cmake errored out if you don't disable >> it explicitly by passing `-DHAVE_BABELTRACE=OFF` to cmake. babeltrace >> support is always optional, but it's ON by default. > > Hi Kefu, > > Ah, that made me wonder. I looked at the code in ./CMakeLists.txt and it > had been in there already for a long time. But missed the fix in the > findXXX files. So I started wondering where the other switch was. > BUt I understand that it was just "(bad)luck" on FreeBSD. actually, (bad)luck on any env without babeltrace installed and with the default cmake project settings. > > The suggested fix will work. > Like I said after the vacation I'll check to see what happens when I try > binding with babeltrace. > -- Regards Kefu Chai -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
