+ ceph-devel On Fri, Mar 24, 2017 at 11:58 AM, Andrew N Solomon <asolomon@xxxxxxxxxx> wrote: > Kefu- > > Regarding the pull request you've been reviewing: > https://github.com/ceph/ceph/pull/13909 > > I had assumed perhaps you were on vacation since you hadn't commented in a > few days Hi Andy, i am not on vacation, just didn't get a chance to take another look at your updated PR. will do it now. > but I noticed today you are probably around since you replied to some of the > content on the > ceph-devel mailing list. Regardless, I'm sure you're busy so I appreciate > you taking the time > to review the pull request. > > This is my first contribution to the ceph project so I'm not entirely sure > what to expect in terms > of the review process, whether any other reviewers besides yourself are > expected to approve the > drop before it gets pulled in, and in general what happens next. any ceph reviewers can review the PRs, but not certain developer are expected to do so, unless you request him/her to review your change. in general, we will add needs-qa label on github, and pull it in a rados-qa suite, and if the tests look good. we will merge it. > > If there is anything more you need from my end on the review, please let me > know. > Do you think it is likely this will make it in time for the upcoming > luminous release? i think so. =) > > Thanks, > Andy > --- > Andy Solomon > Power Open Source Storage Software > asolomon@xxxxxxxxxx > (512)286-8657 -- Regards Kefu Chai -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
