On 9 March 2017 at 04:42, Robin H. Johnson <robbat2@xxxxxxxxxx> wrote: > On Wed, Mar 08, 2017 at 04:21:18PM +0800, Jiaying Ren wrote: >> Hi~ Yehuda and Ceph developers: >> >> We're trying to implement S3 feature bucket >> logging (http://docs.aws.amazon.com/AmazonS3/latest/dev/ServerLogs.html). > ... >> Any comments are appreciated.Thx. > > Strongly in favour of this from my end, and willing to find some cycles > to help you test/review it. > > One thing that comes to mind, is ensuring logging of the correct client > IP when a load-balancer (eg HAProxy) is used in front of the RGW > instances. The internal IP of the load balancer should NOT be > written/exposed in the logs. Hi~ Robin: Thx for reminding. It seems current impl define a config option rgw_remote_addr_param(https://github.com/ceph/ceph/blob/master/src/rgw/rgw_log.cc#L343) to replace internal IP? > > -- > Robin Hugh Johnson > Gentoo Linux: Dev, Infra Lead, Foundation Trustee & Treasurer > E-Mail : robbat2@xxxxxxxxxx > GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85 > GnuPG FP : 7D0B3CEB E9B85B1F 825BCECF EE05E6F6 A48F6136 -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
