Hello Jan Kara,
The patch 165a5e22fafb: "block: Move bdi_unregister() to
del_gendisk()" from Feb 8, 2017, leads to the following static
checker warning:
drivers/block/rbd.c:4117 rbd_free_disk()
warn: variable dereferenced before check 'disk->queue' (see line 4116)
drivers/block/rbd.c
4107 static void rbd_free_disk(struct rbd_device *rbd_dev)
4108 {
4109 struct gendisk *disk = rbd_dev->disk;
4110
4111 if (!disk)
4112 return;
4113
4114 rbd_dev->disk = NULL;
4115 if (disk->flags & GENHD_FL_UP) {
4116 del_gendisk(disk);
^^^^^^^^^^^^^^^^^
The patch introduces a new dereference inside this function call.
4117 if (disk->queue)
^^^^^^^^^^^
Check is too late.
4118 blk_cleanup_queue(disk->queue);
4119 blk_mq_free_tag_set(&rbd_dev->tag_set);
4120 }
4121 put_disk(disk);
4122 }
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
