Hi, Sage I have issued a PR: https://github.com/ceph/ceph/pull/13414 2017-02-14 22:11 GMT+08:00 Sage Weil <sage@xxxxxxxxxxxx>: > On Tue, 14 Feb 2017, liuchang0812 wrote: >> Hi, Sage and Cephers: >> >> I saw a issue "add override where possible when implementing an >> interface". So I used a LLVM tool called clang-tidy to do it >> automatically. . >> >> I have made a big changes: >> >> 246 files changed, 1305 insertions(+), 1305 deletions(-) >> >> I could build it successfully, should I make a Pull-Request? > > Yeah sure! If you could break it up by subsystem (rgw, osd, rbd, mds, > everything else) that would help. Thanks! > >> BTW, I am pleasure to write a simple documentation about this tool if >> we need this. > > Sure! Something in doc/dev, or even just an email to the list? > > sage -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html