On Mon, Feb 06, 2017 at 04:16:55PM +0000, David Laight wrote:
> From: Stafford Horne
> > Sent: 05 February 2017 07:08
> > This was causing a build failure for openrisc when using musl and
> > gcc 5.4.0 since the file is not available in the toolchain.
> >
> > It doesnt seem this is needed and removing it does not cause any build
> > warnings for me.
>
> Hmmm... stddef.h is part of the SuS v2.
> Required to get definitions for NULL, offsetof(), ptrdiff_t and size_t.
>
> So any system that is pretending to by unix-like ought to have one.
Hello,
I agree, and also I can see that musl and gcc both do provide it. I am
not sure why its not getting included for kernel builds, I didnt look
into it much because on the other hand...
Linux also provides it in 'linux/stddef.h'. In this case vchiq_shim.c
includes "vchiq_util.h".
which includes "linux/string.h"
which includes "linux/stddef.h"
So the requirement seems satisfied.
I am fine to send a patch to change the include to <linux/stddef.h> as I
mentioned in the cover letter. But I dont think its really needed.
-Stafford
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
