Re: Assert in Pipe.cc in Hammer 0.94.7

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>>     if (reply.tag == CEPH_MSGR_TAG_WAIT) {
>>       ldout(msgr->cct,3) << "connect got WAIT (connection race)" << dendl;
>>       state = STATE_WAIT;
>>       goto stop_locked;
>>     }
>
> You're skipping over the part where, immediately after taking the
> pipe_lock back, we check for this case (and similar ones):
>
>>    pipe_lock.Lock();
>>    if (state != STATE_CONNECTING) {
>>      ldout(msgr->cct,0) << "connect got RESETSESSION but no longer connecting" << dendl;
>>      goto stop_locked;
>>    }
>
> https://github.com/ceph/ceph/blob/v0.94.1.7/src/msg/simple/Pipe.cc#L1078
>
> :)
>
> Obviously there's an issue somewhere or you wouldn't have hit an
> assert, but I'm not sure where and I'm pretty sure if you ever see it
> again, it's something fixed in later source revisions (...which we may
> not have backported once hammer reached EoL).
> -Greg

Sorry my bad. I missed this somehow. :)
Thanks for clearing my doubt.

Thanks,
Padmanabh
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux