Re: XmlFormatter: space isn't allowed in xml tag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I'm working on it, Thanks for all comments

2017-01-12 21:35 GMT+08:00 Sage Weil <sage@xxxxxxxxxxxx>:
> On Thu, 12 Jan 2017, liuchang0812 wrote:
>> ./bin/ceph daemon out/osd.0.asok dump_historic_ops -f xml
>> <OpHistory><num to keep>20</num to keep><duration to
>> keep>600</duration to keep><Ops></Ops></OpHistory>
>
> Any instance where a Formatter element name has a space in it (and
> probably uppercase, for that matter) should be considered a bug and fixed
> (for this very reason).  Please just submit a PR that adds _'s for this
> one.
>
> Thanks!
> sage
>
>
>>
>> I'm not sure whether XML library could decode it, I will have a try
>>
>> 2017-01-12 17:20 GMT+08:00 Robin H. Johnson <robbat2@xxxxxxxxxx>:
>> > On Thu, Jan 12, 2017 at 01:27:33PM +0800, liuchang0812 wrote:
>> >> hi, all
>> >>
>> >> an XML tag cannot contains space in it. see
>> >> https://www.w3.org/TR/2008/REC-xml-20081126/#NT-NameChar.
>> > Where are spaces leaking into the element names?
>> >
>> > I did a refactor of Formatter parters when I was introducing the
>> > HTMLFormatter used by s3website mode, and I don't recall seeing any
>> > cases of accidental space in XML element names, at least in the RGW
>> > side.
>> >
>> > --
>> > Robin Hugh Johnson
>> > Gentoo Linux: Dev, Infra Lead, Foundation Trustee & Treasurer
>> > E-Mail   : robbat2@xxxxxxxxxx
>> > GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85
>> > GnuPG FP : 7D0B3CEB E9B85B1F 825BCECF EE05E6F6 A48F6136
>> --
>> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>>
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux