Re: Bug in mempool::map?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 20 Dec 2016, Igor Fedotov wrote:
> Hi Allen,
> 
> It looks like mempools don't measure maps allocations properly.
> 
> I extended unittest_mempool in the following way but corresponding output is
> always 0 for both 'before' and 'after' values:
> 
> 
> diff --git a/src/test/test_mempool.cc b/src/test/test_mempool.cc
> index 4113c53..b38a356 100644
> --- a/src/test/test_mempool.cc
> +++ b/src/test/test_mempool.cc
> @@ -232,9 +232,19 @@ TEST(mempool, set)
>  TEST(mempool, map)
>  {
>    {
> -    mempool::unittest_1::map<int,int> v;
> -    v[1] = 2;
> -    v[3] = 4;
> +    size_t before = mempool::buffer_data::allocated_bytes();

I think it's just that you're measuring the buffer_data pool...

> +    mempool::unittest_1::map<int,int>* v = new mempool::unittest_1::map<int,int>;

but the map is in the unittest_1 pool?

> +    (*v)[1] = 2;
> +    (*v)[3] = 4;
> +    size_t after = mempool::buffer_data::allocated_bytes();
> +    cout << "before " << before << " after " << after << std::endl;
> +    delete v;
> +    before = after;
> +    mempool::unittest_1::map<int64_t,int64_t> v2;
> +    v2[1] = 2;
> +    v2[3] = 4;
> +    after = mempool::buffer_data::allocated_bytes();
> +    cout << " before " << before << " after " << after << std::endl;
>    }
>    {
>      mempool::unittest_2::map<int,obj> v;
> 
> 
> Output:
> 
> [ RUN      ] mempool.map
> before 0 after 0
>  before 0 after 0
> [       OK ] mempool.map (0 ms)
> 
> It looks like we do not measure ref_map for BlueStore Blob and SharedBlob
> classes too.
> 
> Any ideas?
> 
> Thanks,
> 
> Igor
> 
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux