On Tue, 6 Dec 2016 18:58:41 +1100, Amitay Isaacs wrote: > On Fri, Dec 2, 2016 at 1:17 AM, David Disseldorp <ddiss@xxxxxxx> wrote: > > > Hi, > > > > The attached patch-set implements a cluster mutex helper for Samba CTDB > > using Ceph librados. > > > > ctdb_mutex_ceph_rados_helper_lock can be used as a recovery lock provider > > for CTDB. When configured, split brain avoidance during CTDB recovery > > will be handled using locks against an object located in a Ceph RADOS > > pool. > > > > I've also attached a standalone test script - @Martin: does this belong > > in the ctdb test suite, or can I just commit it as a standalone test? > > It has a few non-standard dependencies: a running Ceph cluster, the > > rados and jq binaries. > > > > Feedback appreciated. > > > > > This code does not belong in ctdb/tools. You can move it to an appropriate > directory in ctdb/utils. > > Please include the test code also as part of the commit. Someone with > ceph-rados setup should be able to run this test. > I would appreciate if you can add few comments in the test script > describing the requirements and how to run the test. Thanks for the feedback, Amitay. Please find a v2 patchset attached, with the following changes: - move ctdb_mutex_ceph_rados_helper under ctdb/utils/ceph - add test_ceph_rados_reclock.sh and document usage Cheers, David -- ctdb/doc/Makefile | 3 +- ctdb/doc/ctdb_mutex_ceph_rados_helper.7.xml | 90 +++++ .../utils/ceph/ctdb_mutex_ceph_rados_helper.c | 334 ++++++++++++++++++ ctdb/utils/ceph/test_ceph_rados_reclock.sh | 151 ++++++++ ctdb/wscript | 19 + 5 files changed, 596 insertions(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
