On Tue, Nov 29, 2016 at 2:59 PM, Yan, Zheng <zyan@xxxxxxxxxx> wrote:
>
>> On 29 Nov 2016, at 21:54, Ilya Dryomov <idryomov@xxxxxxxxx> wrote:
>>
>> On Tue, Nov 29, 2016 at 12:49 PM, Yan, Zheng <zyan@xxxxxxxxxx> wrote:
>>> Current code does not wake up sync waiter if osd replies error
>>> or the request does not want ondisk ack.
>>
>> Hi Zheng,
>>
>> Did you mean to write "and" instead of "or" - "if osd replies error
>> *and* the request does not want ondisk ack”?
>
> I mean ‘or’. The code does not wake up sync waiter in either of these two cases.
It does wake the sync waiter (r_safe_completion) on error, but only
if ondisk ack was requested. If ondisk ack wasn't requested, it's not
woken up, success or error.
By not setting CEPH_OSD_FLAG_ONDISK, the submitter is indicating that
*any* reply is fine. Blocking on the safe reply instead of any reply
in the !CEPH_OSD_FLAG_ONDISK case sounds wrong.
What is the motivation for this patch?
Thanks,
Ilya
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
