When building with gcc-4.9 -Wmaybe-uninitialized, we get a bogus warning in rbd_watch_cb, as the variable is not used at all in the one case in which it is not initialized first: drivers/block/rbd.c: In function ‘rbd_watch_cb’: drivers/block/rbd.c:3690:5: error: ‘struct_v’ may be used uninitialized in this function [-Werror=maybe-uninitialized] drivers/block/rbd.c:3759:5: note: ‘struct_v’ was declared here Later compiler versions fix this, but adding another initialization here is harmless and lets us build cleanly with 4.9 as well. Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> --- drivers/block/rbd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c index abb7162..4ab990b 100644 --- a/drivers/block/rbd.c +++ b/drivers/block/rbd.c @@ -3776,6 +3776,7 @@ static void rbd_watch_cb(void *arg, u64 notify_id, u64 cookie, } else { /* legacy notification for header updates */ notify_op = RBD_NOTIFY_OP_HEADER_UPDATE; + struct_v = 0; len = 0; } -- 2.9.0 -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html