On 4-10-2016 16:42, Willem Jan Withagen wrote: > On 4-10-2016 15:15, John Spray wrote: >> On Tue, Oct 4, 2016 at 2:28 PM, Willem Jan Withagen <wjw@xxxxxxxxxxx> wrote: >>> On 4-10-2016 14:16, John Spray wrote: >>>> On Tue, Oct 4, 2016 at 1:03 PM, Willem Jan Withagen <wjw@xxxxxxxxxxx> wrote: >>>>> On 4-10-2016 08:07, John Spray wrote: >>>>>> As Dan says, `ceph tell` is the new one, the one that sends commands >>>>>> directly from the CLI to the named service (not via the mon). >>>>>> However, this is a bit of a placeholder, as we'll eventually be >>>>>> switching to some commands (especially PG stats ones) to silently go >>>>>> to the mgr instead of the mon. There are various ways of >>>>>> accomplishing that, the simplest one is to have the CLI fetch both mgr >>>>>> and mon command descriptions, and preferentially send commands to >>>>>> matching entries from the mgr. >>>>> >>>>> ATM I had to disable building MGR, because Clang/Python/FreeBSD throw a >>>>> fit when having to compile on of the python files... >>>>> Something to do with function-signatures not matching. >>>>> I'll look into it after I've completed most of my other blocking >>>>> problems. Unless you'd really want to have the compiler errors now, I'll >>>>> fireup a build with MGR on. >>>> >>>> Ah... yeah, I do seem to recall some places the compiler warned about >>>> (perfectly safe) const char* casts. I'll look into cleaning that up, >>>> assuming it's what's making clang unhappy. >>> >>> Clang is a lot more picky at times... But usually I get away with a >>> warning, this time it throws errors. >>> >> >> Can you try this please? >> https://github.com/ceph/ceph/pull/11307 > > Seems we are talking about the same errors. > At least PyObject_CallMethod is what I remember giving the errors. > > I'll put this in and give it a spinf for its money... This is another Clang warning, I guess... But as I read it, it sounds rather true... /usr/srcs/Ceph/work/ceph/src/messages/MMgrReport.h:39:17: warning: comparison of constant 256 with expression of type 'const enum perfcounter_type_d' is always true [-Wtautological-constant-out-of-range-compare] assert(type < 256); ~~~~ ^ ~~~ atleast if enum perfcounter_type_d is a byte. --WjW -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
