On 09/23/2016 11:07 AM, Ilya Dryomov wrote: >> > Generally I prefer validating things as early as possible. >> > >> > But I also value the simplicity of doing it all in one place. >> > These are assertions, so the conditions checked should never >> > really happen anyway. And... now that we're well past doing >> > huge and rapid changes, the code is showing its maturity, so >> > the number of assertions is kind of excessive anyway. > For the record, with this patch we now assert earlier than we were ;) > Also, it doesn't weaken any of the asserts - just moves them to central > location. Yes, you're right, it's even better than I thought. -Alex -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
