On 21/09/2016 04:39, kefu chai wrote: > On Wed, Sep 21, 2016 at 2:04 AM, Ken Dreyer <kdreyer@xxxxxxxxxx> wrote: >> On Tue, Sep 20, 2016 at 9:28 AM, kefu chai <tchaikov@xxxxxxxxx> wrote: >>> agreed, actually, a test-ready ceph-disk needs venv which pip to install the >>> dependencies, but debian pbuilder uses a cleanroom for building packages >>> in which no network access is allowed by default. >> >> I'm curious why we need a virtualenv at all (or why we "pip install" anything) ? >> >> The distros should have all the packaged python-* and python3-* >> dependencies already, right? >> >> If we could switch to using the packaged python dependencies for >> everything, we'd fix the pbuilder USENETWORK issue, and avoid the >> indeterminate nature of depending on whatever happens to be going on >> with pypi. Maybe I'm missing something, though? > > we could. the python modules installed by pip are only used for > testing purpose, like tox, pytest, flake8, testtools, fixtures, i > think we can add them to the Build-Depends list. and let pbuilder to > take care of them. > > @loic what do you think? It's worth a shot. The primary reason for encapsulating this into install-deps.sh was to cope with all supported operating systems with just two package file / directories (I.e. one debian directory with no #if/#else capability and one spec file). More often than not satisfying python requirements with packages is challenging, to say the least (even pip). That being said, the older operating systems are no longer supported and this may not be an issue right now. And when/if it becomes an issue once again in the future we can probably deal with it in a better way. Cheers -- Loïc Dachary, Artisan Logiciel Libre -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
