Re: [PATCH 0/2] rbd_img_obj_exists_submit() fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 15, 2016 at 12:48 PM, David Disseldorp <ddiss@xxxxxxx> wrote:
> On Thu,  1 Sep 2016 16:59:17 +0200, David Disseldorp wrote:
>
>> Hi,
>>
>> This patchset fixes a couple of bugs in the rbd_img_obj_exists_submit()
>> code-path which appear to have been there since the function was first
>> added.
>>
>> Feedback appreciated.
>
> Did anyone get a chance to look at these changes?

Hi David,

I was waiting for Alex to take a look, but then realized that there is
more to fix: img_request is also getting leaked and we can ignore
ceph_osdc_start_request return value, simplifying things.

For the invalid union field use issue, I think we can just skip calling
rbd_osd_req_format_read() for !img_data requests, but I need to double
check.

I'll put together a branch my version of these fixes and ping you.

Thanks,

                Ilya
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux