On Thu, 8 Sep 2016, David Zafman wrote: > Sage, > > Does any code depend on collection_list returning snapshots BEFORE > head/snapdir? I'm trying to improve scrub's overhead per osd_scrub_chunk_max > of objects, but scrub for to do the snapshot consistency analysis it needs the > head objects first. Can we add a collection_list() that returns the objects > in completely reverse order? Or can it be changed to return head/snapdir > objects before the snapshots? The current code has to ignore > osd_scrub_chunk_max in order to find a natural boundary so that the scrub code > can go in reverse order for that segment. collection_list has to return objects in ghobject_t sort order, so it's really bool operator<(const ghobject_t& l, const ghobject_t& r)'s fault that snaps come first. I don't think we can make it go backwards efficiently given how rocksdb etc works. It might be possible to change the ghobject_t sort order, though, but I suspect it'll require a clusterwide osdmap flag again, similar to the sortbitwise thing we did earlier. Blech. How bad is the current workaround? sage -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
