Re: rgw: feedback on auth engine selection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

inline

----- Original Message -----
> From: "Radoslaw Zarzynski" <rzarzynski@xxxxxxxxxxxx>
> To: "Casey Bodley" <cbodley@xxxxxxxxxx>
> Cc: "The Sacred Order of the Squid Cybernetic" <ceph-devel@xxxxxxxxxxxxxxx>
> Sent: Thursday, September 8, 2016 1:19:11 PM
> Subject: Re: rgw: feedback on auth engine selection
> 

> 
> At the moment RGWHandler is dynamically allocated on each
> request. Do we plan to remove only the allocations or go even
> further and make handlers entirely state-less?

That's been on my list of things to eventually do, for a while--in the librgw front-end, it already is.

> 
> > - req_state: contains too many unrelated fields, some of which are
> > transformed in confusing ways over the lifetime of the request. needs to be
> > broken up into smaller, better encapsulated sub-objects
> 
> I'm 100% behind that.

Me too.  Eventually, I'd like avoid needing separate allocations for any subobjects.  This was one of the main places I hoped we copuld use the polymorphic union idea that you called "static pointer." :)

> 
> > - concurrency: move away from a synchronous process_request() to build on
> > asio frontend work
> 
> Sound really interesting.
> 
> 
> Let me propose another requirement:
>  - critical components should facilitate unit testing. In the future
>    they should be covered by reasonable set of unit tests.

sure

> 
> What do you think?
> 
> Regards,
> Radek
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
Matt Benjamin
Red Hat, Inc.
315 West Huron Street, Suite 140A
Ann Arbor, Michigan 48103

http://www.redhat.com/en/technologies/storage

tel.  734-707-0660
fax.  734-769-8938
cel.  734-216-5309
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux