On Tue, Aug 9, 2016 at 4:45 PM, Alex Elder <elder@xxxxxxxx> wrote:
> On 08/09/2016 09:42 AM, Ilya Dryomov wrote:
>> ceph_file_layout::pool_id is now s64. rbd_add_get_pool_id() and
>> ceph_pg_poolid_by_name() both return an int, so it's bogus anyway.
>>
>> Signed-off-by: Ilya Dryomov <idryomov@xxxxxxxxx>
>
> If a pool id is really 64 bits (signed), shouldn't
> rbd_add_get_pool_id() and ceph_pg_poolid_by_name()
> be changed to return that type (first)?
>
> This otherwise looks good.
>
> Reviewed-by: Alex Elder <elder@xxxxxxxxxx>
Yeah, they should, along with s64/u64 inconsistencies...
Thanks,
Ilya
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
