Re: bluestore onode diet and encoding overhead

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Oh, that's good to know! Have you tracked it down at all? I noticed pretty extreme memory usage on the OSDs still, so that might be part of it. I'm doing a massif run now.

Mark

On 07/12/2016 07:40 AM, Igor Fedotov wrote:
That's similar to what I have while running my test case with vstart...
Without Somnath's settings though..


On 12.07.2016 15:34, Mark Nelson wrote:
Hi Somnath,

I accidentally screwed up my first run with your settings but reran
last night.  With your tuning the OSDs are failing to allocate to
bdev0 after about 30 minutes of testing:

2016-07-12 03:48:51.127781 7f0cef8b7700 -1 bluefs _allocate failed to
allocate 1048576 on bdev 0, free 0; fallback to bdev 1

They are able to continue running, but ultimately this leads to an
assert later on.  I wonder if it's not compacting fast enough and ends
up consuming the entire disk with stale metadata.

2016-07-12 04:31:02.631982 7f0cef8b7700 -1
/home/ubuntu/src/markhpc/ceph/src/os/bluestore/BlueFS.cc: In function
'int BlueFS::_allocate(unsigned int, uint64_t,
std::vector<bluefs_extent_t>*)' thread 7f0cef8b7700 time 2016-07-12
04:31:02.627138
/home/ubuntu/src/markhpc/ceph/src/os/bluestore/BlueFS.cc: 1398: FAILED
assert(0 == "allocate failed... wtf")

 ceph version v10.0.4-6936-gc7da2f7
(c7da2f7c869694246650a9276a2b67aed9bf818f)
 1: (ceph::__ceph_assert_fail(char const*, char const*, int, char
const*)+0x85) [0xd4cb75]
 2: (BlueFS::_allocate(unsigned int, unsigned long,
std::vector<bluefs_extent_t, std::allocator<bluefs_extent_t>
>*)+0x760) [0xb98220]
 3: (BlueFS::_compact_log()+0xd5b) [0xb9b5ab]
 4: (BlueFS::_maybe_compact_log()+0x2a0) [0xb9c040]
 5: (BlueFS::sync_metadata()+0x20f) [0xb9d28f]
 6: (BlueRocksDirectory::Fsync()+0xd) [0xbb2fad]
 7: (rocksdb::DBImpl::WriteImpl(rocksdb::WriteOptions const&,
rocksdb::WriteBatch*, rocksdb::WriteCallback*, unsigned long*,
unsigned long, bool)+0x1456) [0xbfdb96]
 8: (rocksdb::DBImpl::Write(rocksdb::WriteOptions const&,
rocksdb::WriteBatch*)+0x27) [0xbfe7a7]
 9:
(RocksDBStore::submit_transaction_sync(std::shared_ptr<KeyValueDB::TransactionImpl>)+0x6b)
[0xb3df2b]
 10: (BlueStore::_kv_sync_thread()+0xedb) [0xaf935b]
 11: (BlueStore::KVSyncThread::entry()+0xd) [0xb21e8d]
 12: (()+0x7dc5) [0x7f0d185c4dc5]
 13: (clone()+0x6d) [0x7f0d164bf28d]
 NOTE: a copy of the executable, or `objdump -rdS <executable>` is
needed to interpret this.


On 07/12/2016 02:13 AM, Somnath Roy wrote:
Thanks Mark !
Yes, quite similar result I am also seeing for 4K RW. BTW, did you
get chance to try out the rocksdb tuning I posted earlier ? It may
reduce the stalls in your environment.

Regards
Somnath

-----Original Message-----
From: ceph-devel-owner@xxxxxxxxxxxxxxx
[mailto:ceph-devel-owner@xxxxxxxxxxxxxxx] On Behalf Of Mark Nelson
Sent: Tuesday, July 12, 2016 12:03 AM
To: ceph-devel
Subject: bluestore onode diet and encoding overhead

Hi All,

With Igor's patch last week I was able to get some bluestore
performance runs in without segfaulting and started looking int the
results.
Somewhere along the line we really screwed up read performance, but
that's another topic.  Right now I want to focus on random writes.
Before we put the onode on a diet we were seeing massive amounts of
read traffic in RocksDB during compaction that caused write stalls
during 4K random writes.  Random write performance on fast hardware
like NVMe devices was often below filestore at anything other than
very large IO sizes.  This was largely due to the size of the onode
compounded with RocksDB's tendency toward read and write amplification.

The new test results look very promising.  We've dramatically
improved performance of random writes at most IO sizes, so that they
are now typically quite a bit higher than both filestore and older
bluestore code.  Unfortunately for very small IO sizes performance
hasn't improved much.  We are no longer seeing huge amounts of
RocksDB read traffic and fewer write stalls.  We are however seeing
huge memory usage (~9GB RSS per OSD) and very high CPU usage.  I
think this confirms some of the memory issues somnath was continuing
to see.  I don't think it's a leak exactly based on how the OSDs were
behaving, but we need to run through massif still to be sure.

I ended up spending some time tonight with perf and digging through
the encode code.  I wrote up some notes with graphs and code snippets
and decided to put them up on the web.  Basically some of the
encoding changes we implemented last month to reduce the onode size
also appear to result in more buffer::list appends and the associated
overhead.
I've been trying to think through ways to improve the situation and
thought other people might have some ideas too.  Here's a link to the
short writeup:

https://drive.google.com/file/d/0B2gTBZrkrnpZeC04eklmM2I4Wkk/view?usp=sharing


Thanks,
Mark
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel"
in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo
info at http://vger.kernel.org/majordomo-info.html
PLEASE NOTE: The information contained in this electronic mail
message is intended only for the use of the designated recipient(s)
named above. If the reader of this message is not the intended
recipient, you are hereby notified that you have received this
message in error and that any review, dissemination, distribution, or
copying of this message is strictly prohibited. If you have received
this communication in error, please notify the sender by telephone or
e-mail (as shown above) immediately and destroy any and all copies of
this message in your possession (whether hard copies or
electronically stored copies).
N�����r��y���b�X��ǧv�^�)޺{.n�+���z�]z���{ay�ʇڙ�,j��f���h���z��w������j:+v���w�j�m��������zZ+�����ݢj"��!tml=


--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux