Not matching event states in ./msg/async/AsyncConnection.cc

[Willem Jan Withagen <wjw@xxxxxxxxxxx>]

Hi,

I 've just rebased, but now I'm getting BUG warnings in del_event()
calls. And I suspect that it is because of the snippet below...

In STATE_CONNECTING EVENT_READABLE is set on sd, but we try a bit latter
to remove EVENT_WRITABLE. Which abort since asserts were added to the
kevent code.

Could it be that in STATE_CONNECTING_RE EVENT_READABLE needs to be removed?

--WjW


./msg/async/AsyncConnection.cc at line 1014
    case STATE_CONNECTING_RE:
      {
        r = net.reconnect(get_peer_addr(), sd);
        if (r < 0) {
          ldout(async_msgr->cct, 1) << __func__ << " reconnect failed "
<< dendl;
          goto fail;
        } else if (r > 0) {
          ldout(async_msgr->cct, 10) << __func__ << " nonblock connect
inprogress" << dendl;
          center->create_file_event(sd, EVENT_WRITABLE, read_handler);
          break;
        }

      lderr(async_msgr->cct) << __func__ << ":" <<__LINE__
        << " delete_file_event(" << sd << ", EVENT_WRITABLE)"
        << dendl;
        center->delete_file_event(sd, EVENT_WRITABLE);
        state = STATE_CONNECTING_WAIT_BANNER;
        break;
      }

--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html