I have a question regarding the implementation of list images in a consistency group. For referencing images I use their ids and pool ids, since image's name and pool's name are subject to change. In order to list the images in a consistency group I have a function: cg_list_images. This function only returns ids and pool ids. I presume normally users would like to see names instead of ids. Everything in rbd class is written the way that it accepts ioctx. Which is a handle for accessing pool. It means(in my opinion) that everything in rbd class should accept ioctx. As such, I can't open another ioctx when I'm already inside rbd class. It leaves me no choice, but to implement image's name resolution in tools/rbd/action/ConsGrp.cc. In this case only command line users can have images' names, but not other services that use librbd library. Is it fine? On Thu, Apr 28, 2016 at 11:06 AM, Victor Denisov <vdenisov@xxxxxxxxxxxx> wrote: > I created a pull request for preliminary review: > https://github.com/ceph/ceph/pull/8816 > Please leave your comments if you have any. Currently it only has the > following operations implemented: > > - create consistency group > - remove consistency group > - add image to consistency group > - remove image from consistency group > - list consistency groups > > > On Wed, Apr 27, 2016 at 10:50 AM, Jason Dillaman <jdillama@xxxxxxxxxx> wrote: >> On Tue, Apr 26, 2016 at 6:33 PM, Victor Denisov <vdenisov@xxxxxxxxxxxx> wrote: >>> One quick question: is image id unique across all pools? I'm >>> referencing image using 'image_<image id>' key and then keeping pool >>> id in the omap value. >>> Is it safe? >> >> >> No -- the image id is only guaranteed to be unique within the pool >> that owns the image. You can use the pool id in combination with the >> image id to form a unique key. >> >> -- >> Jason -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
