Re: memcpy() avoidance using decode(bufferlist)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 04/22/2016 09:53 AM, David Disseldorp wrote:
Hi,

A question regarding bufferlist usage:

I'm working on the cmpext librados C API, and want to decode the OSD
response directly into a (char *buf/size_t len) buffer provided by the
caller.

I figured this would be straightforward via:
   bl.push_back(buffer::create_static(buf, len));
   ...
   ::decode_nohead(iter.get_remaining(), bl, iter);

However, the decoded data doesn't make it into buf, unless an extra copy
occurs via:
   bl.copy(0, bl.length(), buf);

Any suggestions on a clean way to avoid the extra copy here?

Cheers, David
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Hi David,

The decode logic is appending data to the end of the given bufferlist, which is why it's skipping over the buffer pointer that you provide. Internally, buffer::list is allocating its own 'buffer::ptr append_buffer' to batch these appends. This append_buffer is not currently exposed by the interface, but if there was a way to provide your own buffer::ptr from buffer::create_static(), you could hypothetically use that to avoid the copy.

Casey
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux