On 18-4-2016 23:53, Ali Maredia wrote:
Ceph community,
Recently certain tests that are run in `make check` (one's that end
in .sh and a handful of others) were changed to remove relative paths
and hard coded directories (".libs" was littered throughout the
codebase).
These test scripts pass when you run `make check` because of preset
environment variables in CTest and in src/Makefile.am (CEPH_BIN,
CEPH_ROOT, CEPH_LIB, CEPH_BUILD_DIR, etc.) that are meant to replace
the relative paths from before. However running these tests by
themselves after an autotools build without setting those variables
before hand will result in failures.
I understand how these recent changes disrupt developers workflows
and plan on issuing a fix that defines those environment variables
according to which build system you build with ASAP.
Finally I strongly encourage developers to transition to using CMake
and CTest (run ctest -V -R {test_name} from CMAKE_BINARY_DIR), and
submit fixes and other contributions.
Hi Ali,
I'm trying to get a port for FreeBSD working, and started from make(gmake)
because Cmake did not work that well when I started.
And as such I do always follow the regular pattern and just use the
makefiles as they are. Just because running Make at the top level is a
rather long process. So I keep a script where I run the tests that are
still giving me faults. And it does complete different things from what
make does. Because make assuems that things are going to complete with
success, but in my case I'm actually expecting things to go wrong. :) So
then I start collecting cores and logfiles for post-mortum analysis.
So I'd like to be able to run every test on its own.
And even when I would migrate to Cmake, I would still want to be able to
do that.
So they even have to work if you do not use a build system, it would be
very nice if things are backwards compatible.
And yes, I also want to go to Cmake, because autobuild it an odd bucket
of bits, but preferably not right now.
Thanx,
--WjW
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
