On Mon, Apr 11, 2016 at 4:29 PM, Jason Dillaman <dillaman@xxxxxxxxxx> wrote:
>> > >
>> > >You can still bypass the limitation by using --pool, --image, and
>> > >--snap options, and I would recommend to always use these in scripts
>> > >instead of specs.
>> > >
>> > True, but even if I specify image name with --image argument it still goes
>> > through rbd::utils::extract_spec function (or set_pool_image_name in old
>> > code) so there's no way to put there any raw name I want.
>>
>> Ah, it is rather unfortunate!
>>
>> I expected that with --image argument you could only specify image
>> name, but now I see we even have a comment in the code:
>>
>> // despite the separate pool and snapshot name options,
>> // we can also specify them via the image option
>>
>> I would prefer if it was possible to specify only image name with
>> --image argument, but I guess it would cause backward compatibility
>> issues, so, the simplest solution may be to ease the regexp to:
>>
>> "^(?:([^/@]+)/)?([^@]+)(?:@([^@]+))?$" ?
>>
>> Or may be even:
>>
>> "^(?:([^/@]+)/)?([^@]+)(?:@(.+))?$" ?
>>
>
> It would probably make sense to relax it for non-create operations and use a strict regex for create/clone/import/rename operations.
I think it would also make sense to start enforcing a limit on the
length of the image name on create/clone/etc. I'm not pushing for it
to be 96 chars (although I do believe it'd be sensible), just that we
don't want it to be RADOS - strlen("rbd_id.").
Thanks,
Ilya
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
