Re: Fixes: lines in commit messages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 28, 2016 at 9:09 AM, Nathan Cutler <ncutler@xxxxxxx> wrote:
> Greetings, Ceph developers:
>
> As the number of GitHub pull requests rises (currently in the 8000s), we are
> starting have trouble with unrelated PRs getting closed automatically by the
> "Fixes: #...." lines in PR descriptions and commit messages.
>
> For example, if you open PR#9534 that fixes tracker issue#8069, including a
> line "Fixes: #8069" will cause PR#8069 to be closed - obviously, this is
> wrong but it's the way GitHub works.
>
> Sage suggested that we work around this by referring to the tracker issue by
> its full URL. I opened a PR changing SubmittingPatches to reflect this:
>
> https://github.com/ceph/ceph/pull/8312
>
> Any objections?

Sounds good to me. Truly depressing about GitHub, but sounds good.
-Greg
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux