> On Jan 12, 2016, at 21:36, Nicholas Krause <xerofoify@xxxxxxxxx> wrote: > > This removes the unneeded lock/unlocking of the session mutex as > part of the structure pointer s of type ceph_mds_session as this > locking/unlocking of the session mutex does not protect any > critical region and thus only wastes time in acquiring and unlocking > this mutex in the function drop_leases. > > Signed-off-by: Nicholas Krause <xerofoify@xxxxxxxxx> > --- > fs/ceph/mds_client.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c > index 51cb02d..f987054 100644 > --- a/fs/ceph/mds_client.c > +++ b/fs/ceph/mds_client.c > @@ -3322,8 +3322,6 @@ static void drop_leases(struct ceph_mds_client *mdsc) > if (!s) > continue; > mutex_unlock(&mdsc->mutex); > - mutex_lock(&s->s_mutex); > - mutex_unlock(&s->s_mutex); > ceph_put_mds_session(s); > mutex_lock(&mdsc->mutex); > } the lock/unlock waits any code in critical region to exit > -- > 2.1.4 > -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
