hi, Roy: My previous performance data shows that: If we keep them separate and pass them to ObjectStore::queue_transactions() ,the cpu usage of ObjectStore::queue_transactions() would take up from 6.03% to 6.76% compared with re-using op_t items. I am happy if we could git similar performance data. 2015-11-19 10:09 GMT+08:00 Somnath Roy <Somnath.Roy@xxxxxxxxxxx>: > It's a stack allocation there , no 'new' overhead , but, will save one list push_back. So, gain could be negligible. > But, since I am working on a pull request to delete these transaction object from FileStore worker thread , I need to introduce heap allocation on that path as well , reducing one transaction would help there. > > Thanks & Regards > Somnath > > -----Original Message----- > From: 池信泽 [mailto:xmdxcxz@xxxxxxxxx] > Sent: Wednesday, November 18, 2015 6:00 PM > To: Somnath Roy > Cc: ceph-devel@xxxxxxxxxxxxxxx > Subject: Re: Regarding op_t, local_t > > Good catch. I think it does make sense. > > 2015-11-19 9:54 GMT+08:00 Somnath Roy <Somnath.Roy@xxxxxxxxxxx>: >> Hi Sage, >> I saw we are now having single transaction in submit_transaction. But, >> in the replication path we are still having two transaction, can't we merge it to one there ? >> >> Thanks & Regards >> Somnath >> -- >> To unsubscribe from this list: send the line "unsubscribe ceph-devel" >> in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo >> info at http://vger.kernel.org/majordomo-info.html > > > > -- > Regards, > xinze -- Regards, xinze -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
