the op_t items are encoded in issue_op, so after issue_op, we could use it directly instead of local_t items? 2015-10-31 21:18 GMT+08:00 Sage Weil <sage@xxxxxxxxxxxx>: > On Sat, 31 Oct 2015, ??? wrote: >> hi, all: >> >> There are two ObjectStore::Transaction in >> ReplicatedBackend::submit_transaction, one is op_t and the other one >> is local_t. Is that something >> critilal logic we should consider? >> >> If we could reuse variable op_t it would be great. Because it is >> expensive to calling local_t.append(*op_t). >> >> There are similar logic in ReplicatedBackend::sub_op_modify_impl. > > The local_t items are only applied locally; the op_t items are encoded and > sent over the wire to the replicas. > > If append() is expensive we should just refactor to avoid that. IIRC I > got partway down this path but apparently didn't finish. The ObjectStore > interface takes a list of transactions to apply, so I think it's just a > matter of refactoring the interfaces a bit...? > > sage > -- Regards, xinze -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
