On Wed, 14 Oct 2015 19:57:46 +0200, Ilya Dryomov wrote: > On Wed, Oct 14, 2015 at 7:37 PM, David Disseldorp <ddiss@xxxxxxx> wrote: ... > > Ping, any feedback on the patch? > > The patch itself looks OK, except for the part where you rename a local > variable for no reason, AFACT. Thanks for the feedback Ilya. I presume you're referring to the pagelist -> req_pagelist rename - I'll drop that change and send an update. > We've discussed some of this last week. As it is, all rbd image > properties are stored in omap, so PR info strings stored in xattrs is > something different, but it should be fine for now. I'd rather not > merge any kernel patches related to rbd-target work until we see > a complete patchset though. There's been a lot of back and forth > between Mike, Christoph and target people and the general approach had > changed at least twice, so I'd like to wait for things to settle down. I understand the desire to wait on any RBD-target changes until upstream consensus has been reached, but I'd argue that this change is isolated, and complementary to the existing SETXATTR / CMPXATTR support. Cheers, David -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
