On Wed, 29 Jul 2015 04:31:41 -0500, Mike Christie wrote: > On 07/28/2015 08:15 PM, David Disseldorp wrote: > > Hi Mike, > > > > This RFC patch-set expands on your recently proposed cluster API changes > > to add rbd_tcm COMPARE AND WRITE support. > > > > Rather than offloading the entire COMPARE AND WRITE operation to the > > cluster back-end, these changes extend on the existing local semaphore > > usage, to additionally take an RBD COMPARE AND WRITE device lock. RBD > > device lock acquisition is handled via a newly added rbd_tcm workqueue. > > > > I'd appreciate feedback on the overall direction of these changes. > > > > I will take a look at them. I just posted my patches too :) Thanks for posting your new patch-set. > I originally did not want to use cluster locking because I did not want > to have to grab a cluster lock every time we execute the command. I > tried to take advantage that we know which OSD the compare and write is > going to go to, so we can just send the op to it and it can do locking > on the OSD side. Offloading the entire read/compare/write operation to the OSD is *much* nicer. Consider my RFC patch-set revoked :) Cheers, David -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
