On 04/29/2015 02:10 PM, Wido den Hollander wrote:
> Hi,
>
> In the process of upgrading a cluster from Giant to Hammer I saw this
> on the OSD logs:
>
> 2015-04-29 14:02:37.015454 7f887875e900 -1 osd.456 43089
> set_disk_tp_priority(22) Invalid argument:
> osd_disk_thread_ioprio_class is but only the following values are
> allowed: idle, be or rt
>
> That is correct, since config_opts.h says:
>
> OPTION(osd_disk_thread_ioprio_class, OPT_STR, "") // rt realtime be
> best effort idle
>
> It's nothing bad, but it would be nicer if we got rid of it.
>
> What to do here? Allow "" as a config setting and then ignore it or
> set the default to rt, be or idle?
>
I see there actually is a check for it:
if (cct->_conf->osd_disk_thread_ioprio_class.empty() ||
cct->_conf->osd_disk_thread_ioprio_priority < 0)
return;
So empty() does not return True there while it should since the setting
is set to ""?
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Wido den Hollander
42on B.V.
Ceph trainer and consultant
Phone: +31 (0)20 700 9902
Skype: contact42on
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
