Oh, sorry for the mistake. The fix should be:
> + for (int i = 0; i < 10000; i++) {
> + int s = ::socket(AF_INET, SOCK_STREAM, 0);
> + center.create_file_event(s, EVENT_READABLE, e);
> + sds.push_back(::socket(AF_INET, SOCK_STREAM, 0));
> + }
> +
we need to change i->s, create_file_event will register a event
associated with "socket" and specified event.
On Wed, Feb 11, 2015 at 4:54 AM, Gregory Farnum <greg@xxxxxxxxxxx> wrote:
> Haomai,
>
> On Sun, Feb 8, 2015 at 2:22 AM, ceph.git <ceph-commit@xxxxxxxx> wrote:
>> This is an automated email from the git hooks/post-receive script. It was
>> generated because a ref change was pushed to the repository containing
>> the project "".
>>
>> The branch, master has been updated
>> via 541a8f735523808b076b15bac5b063d0671faeee (commit)
>> via d2eaeea081a729f9c5b4fb0386c717a21becdb1d (commit)
>> via f9114114dc05b0b371fa3d4b87516f1bebf08216 (commit)
>> via c252e05a51523f35eea17355ffc19737db1e47d9 (commit)
>> via 2b6b100a9b61e908c745c70c6d0ccb196a4e1bd7 (commit)
>> from f2de124a20030367162641237f782c0a1d55fb82 (commit)
>>
>> Those revisions listed above that are new to this repository have
>> not appeared on any other notification email; so we list those
>> revisions in full, below.
>>
>> - Log -----------------------------------------------------------------
>> commit 541a8f735523808b076b15bac5b063d0671faeee
>> Merge: f2de124 d2eaeea
>> Author: Sage Weil <sage@xxxxxxxxxx>
>> Date: Sun Feb 8 02:21:33 2015 -0800
>>
>> Merge pull request #3665 from yuyuyu101/wip-fix-qa
>>
>> AsyncConnection: Fix several bugs from qa test
>>
>> Reviewed-by: Sage Weil <sage@xxxxxxxxxx>
>>
>> commit d2eaeea081a729f9c5b4fb0386c717a21becdb1d
>> Author: Haomai Wang <haomaiwang@xxxxxxxxx>
>> Date: Sun Feb 8 15:47:39 2015 +0800
>>
>> AsyncConnection: fix incorrect condition for exchanging in_seq
>>
>> Originally we use "in_seq==0" to judge whether need to exchange in_seq,
>> it's wrong when peer side already receive message and need to reply new
>> in_seq to this side.
>>
>> Now use "is_reset_from_peer" to indicate whether not need to exchange
>>
>> Signed-off-by: Haomai Wang <haomaiwang@xxxxxxxxx>
>>
>> commit f9114114dc05b0b371fa3d4b87516f1bebf08216
>> Author: Haomai Wang <haomaiwang@xxxxxxxxx>
>> Date: Thu Feb 5 10:48:00 2015 +0800
>>
>> NetHandler: Lower connect failed log level
>>
>> Signed-off-by: Haomai Wang <haomaiwang@xxxxxxxxx>
>>
>> commit c252e05a51523f35eea17355ffc19737db1e47d9
>> Author: Haomai Wang <haomaiwang@xxxxxxxxx>
>> Date: Thu Feb 5 10:40:35 2015 +0800
>>
>> AsyncConnection: fixup for 2ffacbe (crc configuration in messenger)
>>
>> Learn from commit d5d1e27d9190463f484f896456ae6a9b5ea15cf8
>>
>> Signed-off-by: Haomai Wang <haomaiwang@xxxxxxxxx>
>>
>> commit 2b6b100a9b61e908c745c70c6d0ccb196a4e1bd7
>> Author: Haomai Wang <haomaiwang@xxxxxxxxx>
>> Date: Thu Feb 5 02:06:55 2015 +0800
>>
>> AsyncConnection: Don't delete event if fd < 0
>>
>> Signed-off-by: Haomai Wang <haomaiwang@xxxxxxxxx>
>>
>
> <snip>
>
>> +class FakeEvent : public EventCallback {
>> +
>> + public:
>> + void do_request(int fd_or_id) {}
>> +};
>> +
>> +TEST(EventCenterTest, FileEventExpansion) {
>> + vector<int> sds;
>> + EventCenter center(g_ceph_context);
>> + center.init(100);
>> + EventCallbackRef e(new FakeEvent());
>> + for (int i = 0; i < 10000; i++) {
>> + int s = ::socket(AF_INET, SOCK_STREAM, 0);
>> + center.create_file_event(i, EVENT_READABLE, e);
>> + sds.push_back(::socket(AF_INET, SOCK_STREAM, 0));
>> + }
>> +
>> + for (vector<int>::iterator it = sds.begin(); it != sds.end(); ++it)
>> + center.delete_file_event(*it, EVENT_READABLE);
>> +}
>> +
>> INSTANTIATE_TEST_CASE_P(
>> AsyncMessenger,
>> EventDriverTest,
>
> This is popping up a warning on the gitbuilders because the variable
> "s" is unused. I went to provide a quick fix and realized I don't know
> what the fix should be — it looks like this test creates two sockets
> on every event and tosses out the first one for some reason. Is it
> supposed to be doing something else? :)
> -Greg
--
Best Regards,
Wheat
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
