Hi Loic > We recreated the pull request from wip-mSHEC branch. I'm sorry. I had thought twice and judged it would not be better to change the branch. I'd close our 2nd pull request and delete wip-mSHEC branch. Only #3484 is alive as our mSHEC pull request at this moment. wip-mSHEC : multiple Shingled Erasure Code #3484 https://github.com/ceph/ceph/pull/3484 Best regareds, Takeshi Miyamae -----Original Message----- From: ceph-devel-owner@xxxxxxxxxxxxxxx [mailto:ceph-devel-owner@xxxxxxxxxxxxxxx] On Behalf Of Miyamae, Takeshi Sent: Monday, January 26, 2015 11:22 AM To: Loic Dachary Cc: Ceph Development; Shiozawa, Kensuke/塩沢 賢輔; Nakao, Takanori/中尾 鷹詔; Paul Von-Stamwitz (PVonStamwitz@xxxxxxxxxxxxxx); Kaga, Yoshihiro/加賀 芳宏; Kawaguchi, Shotaro/川口 翔太朗 Subject: RE: mSHEC r33 release Hi Loic, > It looks like the branch from which you created the pull request still is master and not wip-mSHEC. > That's not a problem. It only really becomes a problem if you have more than one pull request going on. I'm sorry that I didn't have such a common sense. We recreated the pull request from wip-mSHEC branch. wip-mSHEC : multiple Shingled Erasure Code #3488 https://github.com/ceph/ceph/pull/3488 Could you change the branch you will pull from? If it were difficult or not good for the reason of logging comment already written, pulling from master branch would also be OK for us and I would remove the latter pull request. Best regards, Takeshi Miyamae -----Original Message----- From: Loic Dachary [mailto:loic@xxxxxxxxxxx] Sent: Sunday, January 25, 2015 1:20 AM To: Miyamae, Takeshi/宮前 剛 Cc: Ceph Development; Shiozawa, Kensuke/塩沢 賢輔; Nakao, Takanori/中尾 鷹詔; Paul Von-Stamwitz (PVonStamwitz@xxxxxxxxxxxxxx); Kaga, Yoshihiro/加賀 芳宏; Kawaguchi, Shotaro/川口 翔太朗 Subject: Re: mSHEC r33 release Hi, On 24/01/2015 10:09, Miyamae, Takeshi wrote: > Hi Loic, > > I have created a pull request of wip-mSHEC. > > wip-mSHEC pull request #3484 > https://github.com/ceph/ceph/pull/3484 > > Besides, we changed the name of our fork repository. > https://github.com/t-miyamae/wip-mSHEC > > I'm not sure that it was done correctly because I am a beginner. > Would you check it, please? It looks like the branch from which you created the pull request still is master and not wip-mSHEC. That's not a problem. It only really becomes a problem if you have more than one pull request going on. Cheers > > Best regards, > Takeshi Miyamae > > -----Original Message----- > From: Loic Dachary [mailto:loic@xxxxxxxxxxx] > Sent: Friday, January 23, 2015 11:40 PM > To: Miyamae, Takeshi/宮前 剛 > Cc: Ceph Development; Shiozawa, Kensuke/塩沢 賢輔; Nakao, Takanori/中尾 鷹詔; Paul Von-Stamwitz (PVonStamwitz@xxxxxxxxxxxxxx); Kaga, Yoshihiro/加賀 芳宏; Kawaguchi, Shotaro/川口 翔太朗 > Subject: Re: mSHEC r33 release > > Thanks, I'll take a look. Could you please create a pull request against the master branch ? When you do so, it will be convenient if you submit from a branch that has a descriptive name such as wip-mSHEC or something similar. > > Cheers > > On 23/01/2015 15:30, Miyamae, Takeshi wrote: >> Hi Loic, >> >> We have released mSHEC r33 just now. >> >> https://github.com/t-miyamae/ceph >> >> NOTABLE CHANGES >> - ensure thread safety >> - support generator matrix cache (added ErasureCodeShecTableCache.cc) >> - refer to the shared jerasure 2.0 library >> - improve verification of return code in test codes >> - add test code for verifying thread safety (added TestErasureCodeShec_thread.cc) >> >> LIMITATION >> - There are still lots of minor problems in test codes. >> We will fix it by 1/26(mon). >> >> Best regards, >> Takeshi Miyamae >> > > -- Loïc Dachary, Artisan Logiciel Libre �{.n�+�������+%��lzwm��b�맲��r��yǩ�ׯzX����ܨ}���Ơz�&j:+v��� ����zZ+��+zf���h���~����i���z� �w���?����&�)ߢf ��.n��������+%������w��{.n����z��u���ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
