Hi, Since the SHEC plugin depends on the jerasure plugin, it would be simpler if it loaded it instead of including it. The main problem with the current inclusion is that it does not compile any SIMD acceleration code and loses the benefit of optimization when the CPU can provide it. There are two ways out of this a) add to the SHEC plugin the same selection that jerasure has (in the Makefile and with something like http://workbench.dachary.org/ceph/ceph/blob/master/src/erasure-code/jerasure/ErasureCodePluginSelectJerasure.cc b) compile jerasure as a convenience library that can be included by both the jerasure and SHEC plugin. The LRC plugin loads the jerasure plugin but the SHEC plugin cannot do the same because the standard API at http://workbench.dachary.org/ceph/ceph/blob/master/src/erasure-code/ErasureCodeInterface.h is not enough. Note that this is not a blocker for the inclusion of the plugin and can be done afterwards. Cheers On 23/01/2015 15:30, Miyamae, Takeshi wrote: > Hi Loic, > > We have released mSHEC r33 just now. > > https://github.com/t-miyamae/ceph > > NOTABLE CHANGES > - ensure thread safety > - support generator matrix cache (added ErasureCodeShecTableCache.cc) > - refer to the shared jerasure 2.0 library > - improve verification of return code in test codes > - add test code for verifying thread safety (added TestErasureCodeShec_thread.cc) > > LIMITATION > - There are still lots of minor problems in test codes. > We will fix it by 1/26(mon). > > Best regards, > Takeshi Miyamae > > N�����r��y���b�X��ǧv�^�){.n�+���z�]z���{ay� ʇڙ�,j��f���h���z� �w��� ���j:+v���w�j�m��������zZ+�����ݢj"��!tml= > -- Loïc Dachary, Artisan Logiciel Libre
Attachment:
signature.asc
Description: OpenPGP digital signature
