Re: [PATCH 1/2] libceph: tcp_nodelay support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 23, 2015 at 2:11 PM, Chaitanya Huilgol
<chaitanya.huilgol@xxxxxxxxx> wrote:
> Chaitanya Huilgol <chaitanya.huilgol@xxxxxxxxxxx>
>
> TCP_NODELAY socket option set on connection sockets,
> disables Nagle’s algorithm and improves latency characteristics.
> tcp_nodelay(default)/no_tcp_nodelay option flags provided to
> enable/disable setting the socket option.
>
> Signed-off-by: Chaitanya Huilgol <chaitanya.huilgol@xxxxxxxxxxx>

My minor nit is the "NO_TCP_NODELAY" and the ensuing things like

        if (!con->msgr->no_tcp_nodelay) {

We should probably do no_tcp_nodelay -> nagle internally to avoid this.

Reviewed-by: Ilya Dryomov <idryomov@xxxxxxxxxx>

Thanks,

                Ilya
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux