On Fri, Jan 23, 2015 at 2:11 PM, Chaitanya Huilgol <chaitanya.huilgol@xxxxxxxxx> wrote: > Chaitanya Huilgol <chaitanya.huilgol@xxxxxxxxxxx> > > TCP_NODELAY socket option set on connection sockets, > disables Nagle’s algorithm and improves latency characteristics. > tcp_nodelay(default)/no_tcp_nodelay option flags provided to > enable/disable setting the socket option. > > Signed-off-by: Chaitanya Huilgol <chaitanya.huilgol@xxxxxxxxxxx> My minor nit is the "NO_TCP_NODELAY" and the ensuing things like if (!con->msgr->no_tcp_nodelay) { We should probably do no_tcp_nodelay -> nagle internally to avoid this. Reviewed-by: Ilya Dryomov <idryomov@xxxxxxxxxx> Thanks, Ilya -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html