On Mon, Jan 12, 2015 at 08:10:48PM +0300, Ilya Dryomov wrote: > Why is this call here? Why not above or below? I doubt it makes much > difference, but from a clarity standpoint at least, shouldn't it be > placed after all the checks and allocations, say before the call to > rbd_img_request_submit()? The idea is to do it before doing real work, but after the request is set up far enough that a cancallation works. For rbd that doesn't do timeouts or cancellations it really doesn't matter too much. I've moved it a little further down after the next trivial check now. > Expanding on REQ_TYPE_FS comment, isn't blk_mq_end_request() enough? > Swap blk_end_request_all() for blk_mq_end_request() and get rid of err > label? The blk_end_request_all should be gone and sneaked back in due to a sloppy rebase. -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
