On Sun, Dec 21, 2014 at 2:24 PM, Ilya Dryomov <ilya.dryomov@xxxxxxxxxxx> wrote: > On Sat, Dec 20, 2014 at 3:34 PM, Rickard Strandqvist > <rickard_strandqvist@xxxxxxxxxxxxxxxxxx> wrote: >> Remove the function ceph_pool_op_name() that is not used anywhere. >> >> This was partially found by using a static code analysis program called cppcheck. > > It's part of pool op infrastructure and I'd rather we use it in > monc_show() than remove it. I'll make a patch. Actually, pool op stuff has been unused for over two years - looks like it was added for rbd create_snap and that got ripped out in 2012. It's unlikely we'd ever need to manage pools or snaps from the kernel client so I think it makes sense to nuke it. Sage? Thanks, Ilya -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html