>From a quick read of the code, calamari just uses "pg dump pgs_brief", and calculates its own totals etc -- this change shouldn't affect it. John On Sun, Dec 21, 2014 at 3:18 PM, Sage Weil <sweil@xxxxxxxxxx> wrote: > I recently switched this around to not to a full 'pg dump' for the > formatted 'pg stat' command. The problem is that the current code that > does the num_pg_by_state uses the state name as the key. This > includes 'active+clean' and other instances of +, which is not a valid > character for an XML token. > > Is calamari relying on this code anywhere or can we switch this > around to be > > <state> > <name>active+clean</name> > <num>123</num> > </state> > > (or equivalent JSON)? > > sage > > > GET pg/stat: json 200 > GET pg/stat: xml 200 > FAILURE: url http://localhost:5000/api/v0.1/pg/stat > Invalid XML returned: "not well-formed (invalid token): line 4, column 40" > Response content: > <response> > <output> > <pg_summary><num_pg_by_state><active+clean>24</active+clean></num_pg_by_state><version>55</version><num_pgs>24</num_pgs><num_bytes>3892</num_bytes><raw_bytes_used>491817414656</raw_bytes_used><raw_bytes_avail>663907856384</raw_bytes_avail><raw_bytes>1217698979840</raw_bytes></pg_summary> > > </output> > <status> > OK > </status> > </response> > _______________________________________________ > ceph-calamari mailing list > ceph-calamari@xxxxxxxxxxxxxx > http://lists.ceph.com/listinfo.cgi/ceph-calamari-ceph.com -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
