Re: [ceph-users] fiemap bug on giant

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Agree with you.

It seemed I made a mistake that only truncate expected size for clone
op but not truncate size for clone_range op.

We need to truncate dst file to expected length if ending with zero
filled section.

On Tue, Nov 25, 2014 at 11:30 AM, Samuel Just <sam.just@xxxxxxxxxxx> wrote:
> I think the bug is actually with FileStore::_do_sparse_copy_range,
> which isn't truncating out properly to create 0 filled sections.
> -Sam
>
> On Mon, Nov 24, 2014 at 6:17 PM, Haomai Wang <haomaiwang@xxxxxxxxx> wrote:
>> Oh, sorry. This series seemed that already backported...
>>
>> On Tue, Nov 25, 2014 at 10:14 AM, Haomai Wang <haomaiwang@xxxxxxxxx> wrote:
>>> Backport this series(https://github.com/yuandong1222/ceph/commit/3f8fb85b341726ae7bb44b4c699707333cd63ccd)
>>> and test again ? Or....
>>>
>>> Actually, my up to ten ceph clusters open this option for nearly one year.....
>>>
>>> On Tue, Nov 25, 2014 at 10:05 AM, Sage Weil <sweil@xxxxxxxxxx> wrote:
>>>> [dropping ceph-users]
>>>>
>>>> On Tue, 25 Nov 2014, Haomai Wang wrote:
>>>>> It's surprised that the test machine run on a very new kernel but
>>>>> occur this problem:
>>>>>
>>>>> plana 47 is 12.04.5 with kernel 3.18.0-rc6-ceph-00024-geb0e5fd
>>>>>
>>>>> plana 50 is 12.04.4 with kernel 3.17.0-rc6-ceph-00002-ge8acad6
>>>>>
>>>>> Which local filesystem is ran on?
>>>>
>>>> This run was XFS.  It looks like it returned a mapping for fewer bytes
>>>> than it was asked for... 54548 turned into 53904.  That's a bit
>>>> disconcerting!  Maybe teh issue is that the start offset wasn't aligned?
>>>>
>>>> sage
>>>>
>>>>
>>>>
>>>>>
>>>>> On Tue, Nov 25, 2014 at 5:03 AM, Samuel Just <sam.just@xxxxxxxxxxx> wrote:
>>>>> > Bug #10166 (http://tracker.ceph.com/issues/10166) can cause recovery
>>>>> > to result in incorrect object sizes on giant if the setting 'filestore
>>>>> > fiemap' is set to true.  This setting is disabled by default.  This
>>>>> > should be fixed in a future point release, though filestore fiemap
>>>>> > will probably continue to default to false.
>>>>> > -Sam
>>>>> > _______________________________________________
>>>>> > ceph-users mailing list
>>>>> > ceph-users@xxxxxxxxxxxxxx
>>>>> > http://lists.ceph.com/listinfo.cgi/ceph-users-ceph.com
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Best Regards,
>>>>>
>>>>> Wheat
>>>>> _______________________________________________
>>>>> ceph-users mailing list
>>>>> ceph-users@xxxxxxxxxxxxxx
>>>>> http://lists.ceph.com/listinfo.cgi/ceph-users-ceph.com
>>>>>
>>>>>
>>>
>>>
>>>
>>> --
>>> Best Regards,
>>>
>>> Wheat
>>
>>
>>
>> --
>> Best Regards,
>>
>> Wheat



-- 
Best Regards,

Wheat
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux