I know I had a couple of pull requests that we weren’t going to merge until after the giant release. This may have applied some of the other ones too. In addition, It isn’t surprising that with a new release some non-release code reviews would be neglected. That being said, this is a good time to remind people to dedicate time to code reviews. David Zafman Senior Developer http://www.inktank.com > On Nov 9, 2014, at 4:08 AM, Joao Eduardo Luis <joao@xxxxxxxxxx> wrote: > > On 11/08/2014 05:32 PM, Loic Dachary wrote: >> Hi Ceph, >> >> In the past few weeks the number of pending pull requests grew from around 20 to over 80. The good thing is that there are more contributions, the problem is that it requires more reviewers. Ceph is not the only project suffering from this kind of problem and attending the OpenStack summit last week reminded me that the sooner it is addressed the better. >> >> After a few IRC discussions some ideas came up and my favorite is that every developer paid full time to work on Ceph dedicates a daily 15 minutes time slot, time boxed, to review pull requests. Timeboxing is kind of frustrating because some reviews require more. It basically means one has to focus on the pull request for ten minutes at most and take five minutes to write a useful comment that helps the author moving forward. But it also is the only way to make room for a daily activity with no risk of postponing it because something more urgent came up. >> >> What do you think ? > > On my calendar, I do have a time slot of one hour each morning to review pull requests and mailing lists but I seldom honor it, especially when I'm caught up in other stuff. > > I'll move it over to lunch so that it has no chance in interfering with other tasks and try to make a habit of it. > > It would also be interesting to see more community involvement. I believe it would be healthy for the project if we could have (at least) a portion of reviews being performed by other people besides solely the paid developers/maintainers. > > -Joao > > -- > Joao Eduardo Luis > Software Engineer | http://ceph.com > -- > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
