RE: Cache pool bug?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Yep.  The pull request looks is correct too, but needs to be squashed into 
a single commit with a Signed-off-by: line and description.

Zhiqiang, I think the reversed logic you just fixed in agent_maybe_evict() 
was partly because this function is filling in atime (which sounds like a 
timestamp) with an *age* (now - p->first).  I think we should change

>       if (*atime < 0)
> 	*atime = now - p->first;

to be 

 *atime = p->first

and/or adjust the caller accordingly...?

sage

[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux