Janne, I have a couple questions and forgive me if I missed something from the past. Did you consider using std::aligned_storage? That way you don't have to worry as much about portability yourself. Also, there is a boost::aligned_storage as well if Ceph can't build against C++11 goodness. A second more general Ceph question is somewhat off-topic. What about C++11 use in the Ceph code base (like in this case)? It's not explicitly prohibited by the coding style document, but I imagine the goal is to build on as many systems as possible and quite a few supported distros have pretty old versions of GCC. I'm asking this because I imagine some of the performance work that's about to happen will want to use things like lockless queues, and then you get into C++11 memory model and std::atomic... etc. - Milosz On Mon, Sep 29, 2014 at 8:34 AM, Janne Grunau <j@xxxxxxxxxx> wrote: > Hi, > > reworked patchset to address the comments in https://github.com/ceph/ceph/pull/2558 > > variable alignment instead of the hardcoded 32-byte alignment > fixed copy and paste error in a comment > change buffer alignment for decoding too (much simpler than the encoding > changes) > > I'll do a github pull request once the last make check run finishes > locally. > > Also available from http://git.jannau.net/ceph.git/log/?h=buffer_align > > regards > > Janne > > -- > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Milosz Tanski CTO 16 East 34th Street, 15th floor New York, NY 10016 p: 646-253-9055 e: milosz@xxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
