Hi Loic, looks very good and removes all the duplication! I will then do the cache modification against this code base including this pull request. Cheers Andreas. ________________________________________ From: Loic Dachary [loic@xxxxxxxxxxx] Sent: 05 August 2014 09:53 To: Andreas Joachim Peters Cc: Ceph Development Subject: ErasureCode base class Hi, Would you have time to review the ErasureCode base class at https://github.com/ceph/ceph/pull/2201 ? It factorizes code that is common to ErasureCodeJerasure and ErasureCodeIsa. While doing so it really helped that you wrote the ErasureCodeIsa decode functions with only minimal changes compared to those in ErasureCodeJerasure. Thanks for that :-) Cheers -- Loïc Dachary, Artisan Logiciel Libre -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
