On Thu, Jul 24, 2014 at 4:31 PM, Alex Elder <elder@xxxxxxxx> wrote:
> On 07/24/2014 03:42 AM, Ilya Dryomov wrote:
>> Make /sys/bus/rbd/devices/<id>/parent show the entire chain of parent
>> images. While at it, kernel sprintf() doesn't return negative values,
>> casting to unsigned long long is no longer necessary and there is no
>> good reason to split into multiple sprintf() calls.
>
> I like the use of a single snprintf() call, it is much less
> cumbersome.
>
> The reason I always cast u64 values to (unsigned long long)
> in printf() calls is because on some 64-bit architectures,
> u64 is defined as simply (unsigned long), so without the
> cast they spit out warnings. I hate this, but it is reality
> (see include/asm-generic/{int-l64.h,int-ll64.h}). You can
> alternatively use %PRIu64 rather than %llu in your format
> strings, but I think I hate that more. Anyway, if you want
> to avoid warnings on all architectures you should fix that.
IIRC all architectures nowadays use int-ll64.h. int-l64.h is used only
in userspace for compatibility.
Thanks,
Ilya
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
